Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website_sale: Enhance category header & footer #162394

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mathysPaul
Copy link
Contributor

Allows building blocks to be added directly after the shared website header and into the footer of specific eCommerce category pages.

This update allows each category page to have unique header and footer elements.

This feature ensures category-specific customization:

  • Building blocks can be placed in the category-specific footer.
  • Blocks can be added to the header right after the website-wide header.
  • Visibility of these blocks is restricted to their respective category pages.
  • Ensures Headers & footers are not shared between parent and child categories.

task-3747565

@mathysPaul mathysPaul self-assigned this Apr 18, 2024
@robodoo
Copy link
Contributor

robodoo commented Apr 18, 2024

Pull request status dashboard.

@mathysPaul mathysPaul force-pushed the master-website_sale-add-building-blocks-to-product-category-pages-matp branch from 890629f to bf8c0ca Compare April 18, 2024 11:56
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 18, 2024
Copy link
Contributor

@vchu-odoo vchu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your work!
LGTM 👍

I was not sure about the position of the footer and confirmed with @paju-odoo that it should be after the products (same manner as the header) like in the screenshot.
image

@paju-odoo
Copy link

Hey, thanks for your work! LGTM 👍

I was not sure about the position of the footer and confirmed with @paju-odoo that it should be after the products (same manner as the header) like in the screenshot. image

Also please note that it should be placed after the pagination if there are several pages for an e-commerce category :)
cc @mathysPaul @vchu-odoo

Allows building blocks to be added directly after the shared website
header and into the footer of specific eCommerce category pages.

This update allows each category page to have unique header and footer
elements.

This feature ensures category-specific customization:
- Building blocks can be placed in the category-specific footer.
- Blocks can be added to the header right after the website-wide header.
- Visibility of these blocks is restricted to their respective
  category pages.
- Ensures Headers & footers are not shared between parent and child
  categories.

task-3747565
@mathysPaul mathysPaul force-pushed the master-website_sale-add-building-blocks-to-product-category-pages-matp branch from bf8c0ca to 1616c6c Compare May 14, 2024 08:16
Copy link
Contributor

@vchu-odoo vchu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
LGTM 👍

Could you please rebase to green the runbot?

Just one small comment.

sanitize_form=False,
translate=html_translate,
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants