-
Notifications
You must be signed in to change notification settings - Fork 23.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] website_sale: Enhance category header & footer #162394
base: master
Are you sure you want to change the base?
[IMP] website_sale: Enhance category header & footer #162394
Conversation
890629f
to
bf8c0ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your work!
LGTM 👍
I was not sure about the position of the footer and confirmed with @paju-odoo that it should be after the products (same manner as the header) like in the screenshot.
Also please note that it should be placed after the pagination if there are several pages for an e-commerce category :) |
Allows building blocks to be added directly after the shared website header and into the footer of specific eCommerce category pages. This update allows each category page to have unique header and footer elements. This feature ensures category-specific customization: - Building blocks can be placed in the category-specific footer. - Blocks can be added to the header right after the website-wide header. - Visibility of these blocks is restricted to their respective category pages. - Ensures Headers & footers are not shared between parent and child categories. task-3747565
bf8c0ca
to
1616c6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
LGTM 👍
Could you please rebase to green the runbot?
Just one small comment.
sanitize_form=False, | ||
translate=html_translate, | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allows building blocks to be added directly after the shared website header and into the footer of specific eCommerce category pages.
This update allows each category page to have unique header and footer elements.
This feature ensures category-specific customization:
task-3747565